add set layout option feature #181
Conversation
|
Looks good, is this BC-compatible by default? |
| } | ||
|
|
||
| $layoutExtraAssetsOptions = self::getLayoutExtraAssetsOptions(); | ||
| if (array_key_exists($layout, $layoutExtraAssetsOptions)) { |
There was a problem hiding this comment.
This section could be problematic when bundling assets, since some stuff is loaded dynamically.
Might be an option to register the additional asset files manually via the ExtraAsset... - although this is not a perfect solution.
There was a problem hiding this comment.
But this stuff (extra assets) is needed by default for specific layout. Maybe, to do it more flexible we can create AdminLteBowerAsset that adds possibility for developers to connect scripts, styles from bower_components directory at almasaeed2010/adminlte package.
But somehow logic that for specific layout options asset connect extra scripts, styles must be present.
There was a problem hiding this comment.
I think also solution can be write a notes to docs that some layouts by default adds extra js, css from bower_components
There was a problem hiding this comment.
But instead of setting a property, how about simply registering AdminLteFixedLayoutAsset instead of AdminLteAsset?
|
@schmunk42 by default |
According to official AdminLTE layout documentation:
layoutproperty atAdminLteAsset.php\dmstr\helpers\AdminLteHelper::layoutHtmlClass()TODO:
Related issues: